From 0f4c9bdef90037cdcbb54f152d0f01e729af0566 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Simon=20Lid=C3=A9n?= <simonliden94@gmail.com>
Date: Fri, 13 Jul 2018 15:31:53 +0200
Subject: [PATCH] Fix issue with select(0) (#2711)

* Fix issue with select(0). Fixes #2658
---
 src/query/builder.js       |  2 +-
 test/unit/query/builder.js | 10 ++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/query/builder.js b/src/query/builder.js
index 485d25882f..ebe3392a6a 100644
--- a/src/query/builder.js
+++ b/src/query/builder.js
@@ -120,7 +120,7 @@ assign(Builder.prototype, {
   // Adds a column or columns to the list of "columns"
   // being selected on the query.
   columns(column) {
-    if (!column) return this;
+    if (!column && column !== 0) return this;
     this._statements.push({
       grouping: 'columns',
       value: helpers.normalizeArr.apply(null, arguments),
diff --git a/test/unit/query/builder.js b/test/unit/query/builder.js
index b4926f7de8..907c5a27f8 100644
--- a/test/unit/query/builder.js
+++ b/test/unit/query/builder.js
@@ -8139,4 +8139,14 @@ describe('QueryBuilder', function() {
       );
     });
   });
+
+  it('Can call knex.select(0)', function() {
+    testquery(qb().select(0), {
+      pg: 'select 0',
+      mysql: 'select 0',
+      mssql: 'select 0',
+      'pg-redshift': 'select 0',
+      oracledb: 'select 0',
+    });
+  });
 });