Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite3.js getCommandsByName #22

Closed
pward123 opened this issue Jul 5, 2013 · 1 comment
Closed

sqlite3.js getCommandsByName #22

pward123 opened this issue Jul 5, 2013 · 1 comment
Labels
bug

Comments

@pward123
Copy link

@pward123 pward123 commented Jul 5, 2013

I was toying around with creating foreign keys and ran into the following...

In sqlite3.js, the getCommandsByName function is using _.where with a function iterator.

  // Get all of the commands with a given name.
  getCommandsByName: function(blueprint, name) {
    return _.where(blueprint.commands, function(value) { return value.name == name; });
  },

Shouldn't that be using either _.find or switch the iterator to a properties hash?

@tgriesser
Copy link
Member

@tgriesser tgriesser commented Jul 17, 2013

Fixed with the other FK commits.

@tgriesser tgriesser closed this Jul 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.