Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

columnInfo is not using wrapIdentifier #2402

Closed
seeden opened this issue Jan 1, 2018 · 2 comments
Closed

columnInfo is not using wrapIdentifier #2402

seeden opened this issue Jan 1, 2018 · 2 comments
Labels
bug

Comments

@seeden
Copy link

@seeden seeden commented Jan 1, 2018

we are using automatic camelCase transition for tableName and columns as well.
but columnInfo is not changing tableName https://github.com/tgriesser/knex/blob/7de07c966a6ab63087b31cbdd10216d3ddbf8230/src/dialects/postgres/query/compiler.js#L79

@elhigu
Copy link
Member

@elhigu elhigu commented Jan 2, 2018

Yeah, there are many places specially in schema methods, which are not using wrapIdentifier correctly. These should be tested and fixed.

@elhigu elhigu assigned elhigu and unassigned elhigu Jan 2, 2018
@elhigu elhigu added the bug label Jan 2, 2018
@koskimas
Copy link
Collaborator

@koskimas koskimas commented Jan 2, 2018

I'm working on a fix for this. I'll submit a PR soon.

koskimas added a commit to koskimas/knex that referenced this issue Jan 2, 2018
koskimas added a commit to koskimas/knex that referenced this issue Jan 2, 2018
@elhigu elhigu closed this in #2405 Jan 2, 2018
elhigu added a commit that referenced this issue Jan 2, 2018
* Make postgres client wrapIdentifierImpl independent of `this` context

 * Also fixes a bug where only single digit indices were accepted.

* add customWrapIdentifier helper for client

 * customWrapIdentifier is one more level of abstraction for the wrapIdentifier "pipeline"
   that allows the custom wrapIdentifier to be called without calling the `wrapIdentifierImpl`

* bufix: use custom wrapIdentifier in columnInfo. fixes #2402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.