Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript types seem to be missing from npm. #2943

Closed
dashmug opened this issue Dec 10, 2018 · 3 comments
Closed

Typescript types seem to be missing from npm. #2943

dashmug opened this issue Dec 10, 2018 · 3 comments

Comments

@dashmug
Copy link

@dashmug dashmug commented Dec 10, 2018

Environment

Knex version: v0.16.1
Database + version: MySQL
OS: MacOS

Bug

The changelog for v0.16.1 mentioned it already includes the typescript typings. However, after updating to v0.16.1, and removing @types/knex, my build now fails due to missing types.

Upon further inspection, my node_modules/knex folder does not contain the types/directory at all.

See screenshot below.

screen shot 2018-12-10 at 3 55 15 pm

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Dec 10, 2018

Gah! We need to fix package.json. Thanks for the report!

@dashmug
Copy link
Author

@dashmug dashmug commented Dec 10, 2018

No worries. Keep up the good work!

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Dec 10, 2018

Should be fixed in 0.16.2

@kibertoad kibertoad closed this Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants