Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version 0.16.4 throws an error and breaks our CI #3139

Closed
tavizon opened this issue Apr 11, 2019 · 7 comments
Closed

New version 0.16.4 throws an error and breaks our CI #3139

tavizon opened this issue Apr 11, 2019 · 7 comments

Comments

@tavizon
Copy link

@tavizon tavizon commented Apr 11, 2019

Environment

Knex version: 0.16.4
Database + version: Mysql v5.5.59
OS: circleCi

Bug

  1. Your 0.16.4 version auto updated from '0.16.3' and this caused our circleCi build process to throw an error and fail when attempting to run migrate:latest. Since this can cause this breaking issue, we feel this release should be re-released as '0.17.0'. This does not occur locally

  2. Error: You are using Node.js 6. Please consider upgrading to Node.js 8+ or add '@babel/polyfill' dependency to the project (knex will automatically load it).
    at Object. (/home/circleci/build/node_modules/knex/knex.js:22:11)
    at Module._compile (module.js:577:32)
    at Object.Module._extensions..js (module.js:586:10)
    at Module.load (module.js:494:32)
    at tryModuleLoad (module.js:453:12)
    at Function.Module._load (module.js:445:3)
    at Module.require (module.js:504:17)
    at require (internal/module.js:20:19)
    at initKnex (/home/circleci/build/node_modules/knex/bin/cli.js:94:16)
    at Command.commander.command.description.option.action (/home/circleci/build/node_modules/knex/bin/cli.js:191:17)
    at Command.listener (/home/circleci/build/node_modules/commander/index.js:315:8)
    at emitTwo (events.js:106:13)
    at Command.emit (events.js:191:7)
    at Command.parseArgs (/home/circleci/build/node_modules/commander/index.js:651:12)
    at Command.parse (/home/circleci/build/node_modules/commander/index.js:474:21)
    at Liftoff.invoke (/home/circleci/build/node_modules/knex/bin/cli.js:280:13)
    Exited with code 1
    .

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Apr 11, 2019

related #2955

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Apr 11, 2019

@tavizon 0.16.5 was just released. Please let us know if it resolves the problem in a satisfatory way.

@tavizon
Copy link
Author

@tavizon tavizon commented Apr 11, 2019

Thank you for the quick response. As soon as the release is available I will update.

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Apr 12, 2019

@tavizon What do you mean? It was released already.

@ricardograca
Copy link
Member

@ricardograca ricardograca commented Apr 12, 2019

It fixed the problem in my case: bookshelf/bookshelf#1970

@tavizon
Copy link
Author

@tavizon tavizon commented Apr 16, 2019

I am good now. I was seeing the changes to master but not the actual release.

Thank you again!

@elhigu
Copy link
Member

@elhigu elhigu commented Apr 16, 2019

@tavizon did you update your knex to 0.16.5?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants