exec() with no callback throws TypeError: undefined is not a function

[tjwebb]

Consider the following simple queries:

Knex('table').where('id', 1).update({ value: "hello" }).exec();
Knex('table').where('id', 1).update({ value: "hello" }).then();

Query 1 succeeds, but then throws:

TypeError: undefined is not a function

Query 2 succeeds with no error.

[tgriesser]

I'm not sure that you'd want to call either of those without a handler, but fair enough, should be fixed.

[tjwebb]

My main point is that behavior should be consistent. Either then() and exec() should both fail, or both should succeed.

[tgriesser]

Yeah, that's a good point - consistency is important, and since the promise A+ spec defines the onFulfilled and onRejected handlers as both being optional, it'd make sense that the exec() handler be optional as well. Thanks for pointing that out.