Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support question mark escaping for knex rendered queries #1058

Conversation

@elhigu
Copy link
Member

@elhigu elhigu commented Nov 13, 2015

Fixes bug in #519 by adding more complete support for \? escape sequence

@rhys-vdw
Copy link
Member

@rhys-vdw rhys-vdw commented Nov 14, 2015

Specific comment here.

@rhys-vdw
Copy link
Member

@rhys-vdw rhys-vdw commented Nov 14, 2015

I'm thinking of merging #886, which I believe would conflict with this change. Are you happy to retarget the changes afterwards?

@elhigu elhigu force-pushed the elhigu:support-question-mark-escaping-for-knex-rendered-queries branch from 95267da to db7e7fe Nov 14, 2015
@elhigu
Copy link
Member Author

@elhigu elhigu commented Nov 14, 2015

@rhys-vdw, sure of course :)

@elhigu
Copy link
Member Author

@elhigu elhigu commented Nov 24, 2015

@rhys-vdw looks like there has been no activity in #886. Maybe this could be already merged?

@rhys-vdw
Copy link
Member

@rhys-vdw rhys-vdw commented Nov 28, 2015

Yep, looks good to be @elhigu. Cheers. 👍

rhys-vdw added a commit that referenced this pull request Nov 28, 2015
…or-knex-rendered-queries

Support question mark escaping for knex rendered queries
@rhys-vdw rhys-vdw merged commit 51ef27b into knex:master Nov 28, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@elhigu elhigu deleted the elhigu:support-question-mark-escaping-for-knex-rendered-queries branch Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants