Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple aggregate functions #110

Merged
merged 4 commits into from Nov 23, 2013

Conversation

@luigy
Copy link
Contributor

@luigy luigy commented Nov 23, 2013

Fixes #108 and it no longer sets the output name to 'aggregate' by default.

before

  // select count(`id`) as aggregate from `accounts`
  knex('accounts').count('id')

now

  // select count(`id`) from `accounts`
  knex('accounts').count('id')

  // select count(`id`) as `aggregate` from `accounts`
  knex('accounts').count('id as aggregate')
tgriesser added a commit that referenced this pull request Nov 23, 2013
@tgriesser tgriesser merged commit 704649c into knex:master Nov 23, 2013
1 check passed
1 check passed
@tgriesser
default The Travis CI build passed
Details
@tgriesser
Copy link
Member

@tgriesser tgriesser commented Nov 23, 2013

Great work, thanks so much @luigy! I'll look to get this rolled into a new version release by the end of the weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants