Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added bigint type to postgresql #111

Merged
merged 1 commit into from Nov 25, 2013
Merged

added bigint type to postgresql #111

merged 1 commit into from Nov 25, 2013

Conversation

@bryanaka
Copy link
Contributor

@bryanaka bryanaka commented Nov 25, 2013

bigint is treated as an integer, since typeBigInteger isn't defined on clients/server/postgres/schemagrammar.js

I was going to write the tests, then I saw that the schemagrammar files are untested... and I don't really think I should write all the tests for the file, especially since I am not familiar with the code base. It would be nice to see it done with mysql or sqlite first.

So your call. I'll make the PR without tests, and you can reject it if you want. I can always help write the tests once I get an example to go off of.

This should help with postgres problems I mentioned in TryGhost/Ghost#1554 and TryGhost/Ghost#1555

@tgriesser tgriesser merged commit f61eea9 into knex:master Nov 25, 2013
1 check failed
1 check failed
@tgriesser
default The Travis CI build failed
Details
@tgriesser
Copy link
Member

@tgriesser tgriesser commented Nov 25, 2013

Thanks, merged & pushed into the 0.5.0 release.

@bryanaka
Copy link
Contributor Author

@bryanaka bryanaka commented Nov 25, 2013

No Problem. Glad to Help 👍

@bryanaka bryanaka deleted the bryanaka:feature/postgres-bigint branch Nov 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants