Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .timeout(ms) to QueryBuilder #1201

merged 1 commit into from Feb 17, 2016


Copy link

@wubzz wubzz commented Feb 14, 2016

A feature suggestion that adds timecontrol over queries to the querybuilder that is being run in an application, similarly to how you can now control the Timeout for acquiring a new conection in 0.10.

Probably not often that this would have a use case, but in complex queries where you have tons of joins and tons of data, this could prove useful. If not for anything else, it can be used for finding queries that are slowing down an app.

This is not a requested feature or anything that I am personally in need of, just something extra.

Copy link

@elhigu elhigu commented Feb 15, 2016

@wubzz if anyhow possible could you rebase this on master and squash some of those back and forth commits? git commit --amend is good way to add fixes to last commit that you did if you find that there was a problem in the commit you just put in. Also git rebase -i origin/master gives you pretty nice control what is getting in and how.

Copy link
Member Author

@wubzz wubzz commented Feb 15, 2016

@elhigu Been trying a Git client with no visual representation built it, so it's a bit odd. I'll try get it sorted. Worst case I'll cherry-pick on a new branch and open a new one.

@wubzz wubzz force-pushed the wubzz:feature/add_timeout_to_querybuilder branch from 9907857 to 6dfe653 Feb 15, 2016
elhigu added a commit that referenced this pull request Feb 17, 2016
@elhigu elhigu merged commit 9f270f0 into knex:master Feb 17, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants