Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lodash from 3.7.0 -> 4.6.0 #1242

Merged
merged 7 commits into from Mar 15, 2016
Merged

Conversation

@wubzz
Copy link
Member

@wubzz wubzz commented Mar 2, 2016

Fixes #1214 . Updates lodash to v4, which affects more or less all project files. I would only include this PR for a big release, even if tests pass.

@wubzz
Copy link
Member Author

@wubzz wubzz commented Mar 2, 2016

Sorry, it looks like my IDE went apeshit on the indentation.. I'll fix this.

@blah238
Copy link
Collaborator

@blah238 blah238 commented Mar 8, 2016

👍 great work @wubzz! Since this is such an integral dependency I agree it would be wise to bump at least the minor version.

@elhigu
Copy link
Member

@elhigu elhigu commented Mar 14, 2016

@wubzz looks good, but need to resolve conflict before being able to merge

@wubzz
Copy link
Member Author

@wubzz wubzz commented Mar 14, 2016

@elhigu Yeah, no problem, I'll resolve those. Though, I'm not sure if we want to merge this already or not. I'm thinking 0.11 to be safe.

@elhigu
Copy link
Member

@elhigu elhigu commented Mar 15, 2016

If we merge this now, next knex release will be 0.11 :) On the other hand if we haven't made any breaking changes since 0.10 we could roll out 0.10.1 already.

EDIT: actually there seem to be breaking changes already introduced after 0.10 e.g. 942877c

@elhigu
Copy link
Member

@elhigu elhigu commented Mar 15, 2016

@wubzz next release will be 0.11 so no need to be on hold with this

@wubzz
Copy link
Member Author

@wubzz wubzz commented Mar 15, 2016

@elhigu Sweet, I'll get this done sometime this week. Do you think Upgrading Bluebird would be appropiate at the same time? There's an issue for this too.

(Seperate PR, of course)

@wubzz wubzz force-pushed the wubzz:update_lodash_dependency branch from 0801997 to 3b7070f Mar 15, 2016
wubzz added a commit that referenced this pull request Mar 15, 2016
@wubzz wubzz merged commit e1ed385 into knex:master Mar 15, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants