Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap index names #1289

Merged
merged 1 commit into from Mar 17, 2016
Merged

Wrap index names #1289

merged 1 commit into from Mar 17, 2016

Conversation

@maxcnunes
Copy link
Contributor

@maxcnunes maxcnunes commented Mar 17, 2016

Pull request already described in this previous one #899.

The only difference of this one is that I have rebased the branch with the master.
And already included wrap index in the new mssql dialect.

I hope is good now for merge.

Thanks

@elhigu
Copy link
Member

@elhigu elhigu commented Mar 17, 2016

Thanks!

elhigu added a commit that referenced this pull request Mar 17, 2016
@elhigu elhigu merged commit c69e649 into knex:master Mar 17, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rhys-vdw rhys-vdw mentioned this pull request Mar 30, 2016
wolfgang42 added a commit to wolfgang42/knex that referenced this pull request Apr 21, 2016
PR knex#1289 made it quote the index/constraint names, but did not update the tests accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants