Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct connection URL parsing for MSSQL #1342

Merged
merged 2 commits into from Apr 29, 2016
Merged

Conversation

@h0vhannes
Copy link
Contributor

@h0vhannes h0vhannes commented Apr 11, 2016

Use connection.server instead of connection.host when connecting to MSSQL

Use connection.server instead of connection.host
when connecting to MSSQL
@rhys-vdw
Copy link
Member

@rhys-vdw rhys-vdw commented Apr 11, 2016

Thanks. Would you be able to add test coverage for this?

@h0vhannes
Copy link
Contributor Author

@h0vhannes h0vhannes commented Apr 11, 2016

Sure, just don't know where to add tests for this. Is it integration or, maybe, tape ?

@rhys-vdw
Copy link
Member

@rhys-vdw rhys-vdw commented Apr 11, 2016

Thanks. If there are none already then I tape is preferable for new tests.

On Tue, Apr 12, 2016, 9:01 AM Hovhannes Kuloghlyan notifications@github.com
wrote:

Sure, just don't know where to add tests for this. Is it integration or,
maybe, tape ?


You are receiving this because you commented.

Reply to this email directly or view it on GitHub
#1342 (comment)

@h0vhannes
Copy link
Contributor Author

@h0vhannes h0vhannes commented Apr 11, 2016

Ok, there are tests for connection URL parser in tape, so I'll add tests there.

@h0vhannes h0vhannes force-pushed the h0vhannes:mssql-conn-urls branch from 66bb931 to 8e41a33 Apr 11, 2016
@wubzz
Copy link
Member

@wubzz wubzz commented Apr 12, 2016

Good catch on this. Just to verify, was this done because it wasn't working properly in 0.10? Given #1239 the initiation should have worked regardless of this. But I do agree this was needed as well.

@h0vhannes
Copy link
Contributor Author

@h0vhannes h0vhannes commented Apr 12, 2016

Yes, 0.10 doesn't work with MSSQL connection urls

@wubzz wubzz merged commit 8a303f1 into knex:master Apr 29, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants