Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use files with the correct extension for migrations #135

Merged

Conversation

@lmorchard
Copy link
Contributor

@lmorchard lmorchard commented Dec 12, 2013

When editing migrations in VIM, I noticed that Knex was picking up the .swp files and throwing an error. This commit filters by extension for just the expected files.

I didn't code up a full-blown test, but the addition of a random crap file in the migration fixtures will trigger the error that this commit fixes.

tgriesser added a commit that referenced this pull request Dec 12, 2013
…st-all

Only use files with the correct extension for migrations
@tgriesser tgriesser merged commit e1be421 into knex:master Dec 12, 2013
1 check passed
1 check passed
@tgriesser
default The Travis CI build passed
Details
@tgriesser
Copy link
Member

@tgriesser tgriesser commented Dec 12, 2013

Ah, good call, thanks @lmorchard!

@lmorchard lmorchard deleted the lmorchard:use-extension-for-migration-list-all branch Dec 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants