Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1348 MSSQL adding and dropping multiple columns fix #1401

merged 1 commit into from May 14, 2016


Copy link

@nickwhiteley nickwhiteley commented May 12, 2016

This is my first pull request so apologies if something isn't right.
It includes changes to MSSQL for adding and dropping columns. Previously single column changes worked but multiple columns didn't.

Copy link

@wolfgang42 wolfgang42 commented May 12, 2016

I can confirm that the tests pass for MSSQL.

This isn't specifically related to your PR, but it looks like the MSSQL unit tests need to be checked to make sure they are actually correct T-SQL.

Copy link
Contributor Author

@nickwhiteley nickwhiteley commented May 13, 2016

Indeed. I have had a quick look and there are 10 which don't have valid T-SQL. I don't have time today but will try to investigate further over the next week.

@rhys-vdw rhys-vdw merged commit 815c6ce into knex:master May 14, 2016
1 check passed
Copy link

@rhys-vdw rhys-vdw commented May 14, 2016

Thanks @nickwhiteley! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants