Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes "a promise was created but was not returned" warning #1460

Merged
merged 1 commit into from Jun 3, 2016

Conversation

@agdevbridge
Copy link
Contributor

@agdevbridge agdevbridge commented May 30, 2016

This would fix Warning: a promise was created in a handler but not returned from it
Issue: #1388

This would fix Warning: a promise was created in a handler but not returned from it
Issue: knex#1388
@kolpav
Copy link

@kolpav kolpav commented Jun 2, 2016

Hope this will be merged soon

@elhigu
Copy link
Member

@elhigu elhigu commented Jun 3, 2016

I was thinking if just return would have been enough to keep previous functionality... but this seems harmless though so I'll just merge.

@elhigu elhigu merged commit b4cef89 into knex:master Jun 3, 2016
1 check passed
@aditbisa
Copy link

@aditbisa aditbisa commented Jun 11, 2016

You forgot to put return in here: (line 49 & 52)

result.then((val) => {
          return transactor.commit(val)
        })
        .catch((err) => {
          return transactor.rollback(err)
        })

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants