Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for specifying a DATABASE_URL without a password #1473

Merged
merged 1 commit into from Jun 13, 2016

Conversation

@robscott
Copy link
Contributor

@robscott robscott commented Jun 7, 2016

Earlier today I found that Knex was not parsing a user from the following DATABASE_URL:

mysql://travis@127.0.0.1:3306/yodel_test

This was because the URL was missing a password. Because pg-connection-string is being used for Postgres connections, this already worked for Postgres URLs. If you want a laugh, feel free to look at my commits from earlier today where I clearly had no idea how I'd broken all our Travis tests by starting to use DATABASE_URL.

PS: Knex is awesome, thanks for all the work on this project.

@rhys-vdw rhys-vdw merged commit d3557a0 into knex:master Jun 13, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rhys-vdw
Copy link
Member

@rhys-vdw rhys-vdw commented Jun 13, 2016

Thanks @robscott. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants