Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency issue with 'node-uuid' #1516

Merged
merged 1 commit into from Jun 19, 2016
Merged

Fix dependency issue with 'node-uuid' #1516

merged 1 commit into from Jun 19, 2016

Conversation

@SuperSpyTX
Copy link
Contributor

@SuperSpyTX SuperSpyTX commented Jun 19, 2016

It appears that in Issue #1510, unique IDs were added to queries. The dependency that was used is a development dependency, which isn't installed by default.

This meant that I could not load this module after installing 0.11.6 (from 0.11.5):

Unhandled rejection Error: Cannot find module 'node-uuid'
    at Function.Module._resolveFilename (module.js:325:15)
    at Function.Module._load (module.js:276:25)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> ()
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> ()
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)

Workaround is simple: use npm install node-uuid

This change makes sure the dependency is installed by default.

It appears that in Issue #1510, unique IDs were added to queries.  The dependency that was used was a development dependency, which isn't installed as a default.  This change makes sure the dependency is installed by default.
@rhys-vdw rhys-vdw added the bug label Jun 19, 2016
rhys-vdw added a commit that referenced this pull request Jun 19, 2016
@rhys-vdw rhys-vdw merged commit fab1d07 into knex:master Jun 19, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rhys-vdw
Copy link
Member

@rhys-vdw rhys-vdw commented Jun 19, 2016

Thanks. Released 0.11.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants