Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect escaping in SqlString.escape #1545

Merged
merged 1 commit into from Jul 1, 2016

Conversation

@voidxnull
Copy link
Contributor

@voidxnull voidxnull commented Jul 1, 2016

It seems like a typo.

Fixes #1520.

@elhigu
Copy link
Member

@elhigu elhigu commented Jul 1, 2016

This would need also test case even that this is really simple fix.

@voidxnull voidxnull force-pushed the voidxnull:fix/string-escape branch from 43672fd to 308307b Jul 1, 2016
@voidxnull voidxnull force-pushed the voidxnull:fix/string-escape branch from 308307b to 626f770 Jul 1, 2016
@voidxnull
Copy link
Contributor Author

@voidxnull voidxnull commented Jul 1, 2016

Done. Let me know if there's anything I can improve.

@elhigu elhigu merged commit 289f17e into knex:master Jul 1, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@elhigu
Copy link
Member

@elhigu elhigu commented Jul 1, 2016

seems legit, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants