Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mssql update query generates invalid syntax #1777

Merged
merged 4 commits into from Dec 6, 2016

Conversation

@rslabbert
Copy link
Contributor

@rslabbert rslabbert commented Nov 9, 2016

The update query for SQL Server requires from when doing a join. The join must also be after the set. See here.

@rhys-vdw
Copy link
Member

@rhys-vdw rhys-vdw commented Dec 6, 2016

Hi @RubenSlabbert. These look good. I don't use MSSQL, but have just looked at this StackOverflow answer to confirm that it's correct.

Thanks for your contribution. Not sure what is going on presently release wise, but I can merge to master.

@rhys-vdw rhys-vdw merged commit 0ae4f3e into knex:master Dec 6, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
elhigu added a commit to elhigu/knex that referenced this pull request Feb 15, 2017
* Updated mssql update compiler with correct syntax

* Updated failing mssql test

* Updated failing tests to add from

* Third times the charm tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants