I really don't like the code duplication between the base Transaction.query implementation and the ones for mysql, mysql2, and maria. For the sake of "keeping dialects separate", I left it as is. Perhaps a better idea just to listen on the query-error event and give the helpers.warn a call there instead?
I'm planning to setup docker container with postgres, mysql, oracle and mssql maybe with that it will be easier to test locally all dialects (hopefully I have time to do it before 2018 :p and permission from microsoft to bundle mssql there...).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.