Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support node-mssql 4.0.0 #2029

Merged
merged 4 commits into from May 21, 2017
Merged

Support node-mssql 4.0.0 #2029

merged 4 commits into from May 21, 2017

Conversation

@ncwgf
Copy link
Contributor

@ncwgf ncwgf commented Apr 26, 2017

Only support node-mssql@^4.0.0

Try to fix #1999

ncwgf added 2 commits Apr 7, 2017
compatible with 3.3.0 & 4.0.1

#1999
eslint src/**
src/dialects/mssql/index.js
  77:1  error  Line 77 exceeds the maximum line length of 100  max-len
@elhigu
Copy link
Member

@elhigu elhigu commented Apr 27, 2017

It would be better to just update the node-mssql from package.json and support only node-mssql >4.

Now one of the code paths gets never tested.

@jjg1914
Copy link

@jjg1914 jjg1914 commented May 19, 2017

Are there any plans for merging this soon, possibly for a 0.13.1 change? This is blocking me from upgrading mssql, and I'd help in any way necessary (big knex.js fan!)

Copy link
Member

@elhigu elhigu left a comment

.

Copy link
Member

@elhigu elhigu left a comment

It would be better to just update the node-mssql from package.json and support only node-mssql 4.

Now one of the code paths gets never tested.

@ncwgf ncwgf changed the title compatible node-mssql 4.0.0 Support node-mssql 4.0.0 May 21, 2017
@elhigu
elhigu approved these changes May 21, 2017
@elhigu elhigu merged commit 17bf763 into knex:master May 21, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@elhigu
Copy link
Member

@elhigu elhigu commented May 21, 2017

Thanks!

@ncwgf ncwgf deleted the ncwgf:node-mssql-4.0 branch May 21, 2017
@lusid
Copy link

@lusid lusid commented Nov 1, 2017

Is this ever going to make it to the version deployed in npm?

@elhigu
Copy link
Member

@elhigu elhigu commented Nov 5, 2017

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants