Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove configOptions connection settings filter for mysql2 #2040

Merged
merged 1 commit into from May 9, 2017

Conversation

@jstewmon
Copy link
Contributor

@jstewmon jstewmon commented May 1, 2017

The whitelist was masking authSwitchHandler, and the docs indicate no such filtering should exist:

The connection options are passed directly to the appropriate database client to create the connection, and may be either an object, or a connection string

@jstewmon
Copy link
Contributor Author

@jstewmon jstewmon commented May 1, 2017

A single test failed for oracle transaction. Unrelated to this change set.

@elhigu
Copy link
Member

@elhigu elhigu commented May 3, 2017

Rerunning the tests... I would like to know why that filter was there in the first place. Removing it sounds like a good idea.

@elhigu
Copy link
Member

@elhigu elhigu commented May 3, 2017

Looks like it has been there from the start. If there are no objections from @tgriesser or @rhys-vdw I'll merge this in few days. Please remind me next week if I forgot.

@jstewmon
Copy link
Contributor Author

@jstewmon jstewmon commented May 8, 2017

Bump

@rhys-vdw
Copy link
Member

@rhys-vdw rhys-vdw commented May 9, 2017

@elhigu 👍

@elhigu elhigu merged commit 804c338 into knex:master May 9, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants