Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for enum columns to SQlite3 dialect #2055

Merged
merged 1 commit into from May 10, 2017
Merged

Conversation

@carragom
Copy link
Contributor

@carragom carragom commented May 10, 2017

Adds support for enum columns in SQLite using a check constraint. Based on the current PostgreSQL implementation. If I missed anything please let me know.

@carragom carragom force-pushed the carragom:master branch from 4ff821c to 9673980 May 10, 2017
@elhigu
Copy link
Member

@elhigu elhigu commented May 10, 2017

Integration test for enum's check constraint would be great to have to actually verify that created constraints function as expected. Otherwise this looks good.

@elhigu
Copy link
Member

@elhigu elhigu commented May 10, 2017

And thanks :)

@carragom carragom force-pushed the carragom:master branch from 9673980 to 0d4771a May 10, 2017
@carragom
Copy link
Contributor Author

@carragom carragom commented May 10, 2017

Ok sorry about that, tests are passing now. Does it look good to you or is there anything else I missed?

@elhigu
Copy link
Member

@elhigu elhigu commented May 10, 2017

This is good. Just need to remember that this is actually breaking change.

@elhigu elhigu merged commit 18581f9 into knex:master May 10, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants