Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed table alter attributes order. (first, after) #2062

Merged
merged 4 commits into from May 15, 2017

Conversation

@why2pac
Copy link
Contributor

@why2pac why2pac commented May 13, 2017

Fixed issue, #1946

Should first and after attributes are placed after comment attribute.

Copy link
Member

@elhigu elhigu left a comment

regression test is missing

@why2pac
Copy link
Contributor Author

@why2pac why2pac commented May 15, 2017

@elhigu I added 2 test cases. At after position with comment and at first position with comment.

@elhigu
Copy link
Member

@elhigu elhigu commented May 15, 2017

Thanks for adding unit tests, but there should be still integration test which uses real DB. Checking only which kind of query is generated is not enough.

https://github.com/tgriesser/knex/blob/master/CONTRIBUTING.md

@why2pac
Copy link
Contributor Author

@why2pac why2pac commented May 15, 2017

@elhigu I added real database test cases.

@elhigu
elhigu approved these changes May 15, 2017
@elhigu
Copy link
Member

@elhigu elhigu commented May 15, 2017

@why2pac awesome, thanks!

@elhigu elhigu merged commit 68af752 into knex:master May 15, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@why2pac
Copy link
Contributor Author

@why2pac why2pac commented May 15, 2017

@elhigu Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants