Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mssql binding ordering for queries that combine a limit with select raw or update #2066

Merged
merged 2 commits into from May 16, 2017

Conversation

@dirkmc
Copy link
Contributor

@dirkmc dirkmc commented May 15, 2017

#1758
Note that I also fixed a couple of unit tests that were passing even though they should have failed

@dirkmc dirkmc changed the title Fix binding ordering for queries that combine a limit with select raw or update Fix mssql binding ordering for queries that combine a limit with select raw or update May 15, 2017
@elhigu
Copy link
Member

@elhigu elhigu commented May 16, 2017

Looks good, thanks. I'll rerun the tests until they passes... I really need to fix that oracledb random fail at some point.

Loading

@elhigu elhigu merged commit 6795170 into knex:master May 16, 2017
1 check passed
Loading
@dirkmc
Copy link
Contributor Author

@dirkmc dirkmc commented May 16, 2017

ha yeah I was surprised the tests failed there, I figured it must be something random as I hadn't changed anything related to oracle. Thanks for the quick update!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants