Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Replaced push.apply() calls with custom concat() function. #207

Merged
merged 4 commits into from Mar 20, 2014
Merged

[Improvement] Replaced push.apply() calls with custom concat() function. #207

merged 4 commits into from Mar 20, 2014

Conversation

@kobalicek
Copy link
Contributor

@kobalicek kobalicek commented Mar 19, 2014

Replaced push.apply() calls with custom concat() function so the V8 stack will not exhaust when a complex query is being processed. It doesn't change the behavior in Knex (tests are passing), it just uses different approach to concatenate to an existing array and provides ability to simply reimplement 'concat' function if new, better approach has been found.

With this change we can run really complex queries on our server without V8 terminating the app.

NOTE: This PR also contains fixes to counting, hope that it's fine.

kobalicek added 2 commits Mar 19, 2014
…tack will not exhaust when a complex query is being processed
tgriesser added a commit that referenced this issue Mar 20, 2014
[Improvement] Replaced push.apply() calls with custom concat() function.
@tgriesser tgriesser merged commit 9028205 into knex:master Mar 20, 2014
1 check passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants