Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for renaming column in postgresql #2099

Merged
merged 1 commit into from Jun 9, 2017

Conversation

@rizip1
Copy link
Contributor

@rizip1 rizip1 commented Jun 3, 2017

There are already unit tests for renaming column but only for oracle.
I figured out that unit testing sqlite, mssql and mysql can not be
done nicely using only toSQL method but is implemented
in test/integration/builder/additional.js. However test for
postgresql can be done similarly to oracle using no dirty checks
so maybe it can be added.

@rizip1 rizip1 force-pushed the rizip1:add-rename-column-test branch 3 times, most recently from 1bb27cf to ecefcf4 Jun 3, 2017
@rizip1
Copy link
Contributor Author

@rizip1 rizip1 commented Jun 3, 2017

When I run npm run test locally tests pass without error. However here it fails in oracle | oracledb part that I have not touched. Does anybody have any idea what is wrong? Thanks for help.

@rizip1 rizip1 force-pushed the rizip1:add-rename-column-test branch 2 times, most recently from fde91d3 to 4b50cb4 Jun 4, 2017
@rizip1 rizip1 force-pushed the rizip1:add-rename-column-test branch from 4b50cb4 to 7c1de04 Jun 4, 2017
@elhigu
Copy link
Member

@elhigu elhigu commented Jun 9, 2017

Thanks! Yeah oracle fail is random fail that no one has had time to fix. Sorry about that. I'll try to make test pass and merge after that.

@elhigu elhigu merged commit e884903 into knex:master Jun 9, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants