Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for cross-join #2102

Merged
merged 1 commit into from Jun 9, 2017
Merged

Add unit test for cross-join #2102

merged 1 commit into from Jun 9, 2017

Conversation

@rizip1
Copy link
Contributor

@rizip1 rizip1 commented Jun 4, 2017

Add unit test for cross-join as there was no one currently.
In the first test-case I test composition of two cross-joins.
In the second test-case I test cross-join with on statement.
I found out that cross-join with on is only valid for MySQL
and sqlite3 so the test includes only these (it is weird to use
cross-join with on anyhow).

@rizip1 rizip1 force-pushed the add-cross-join-u-test branch from 0e77213 to 20935e9 Jun 4, 2017
* Test composition of two cross joins

* Test cross-join with 'on' statement
  (same as inner join) only for sqlite3 and mysql
  because not supported elsewhere
@rizip1 rizip1 force-pushed the add-cross-join-u-test branch from 20935e9 to b6a5db8 Jun 4, 2017
@elhigu
Copy link
Member

@elhigu elhigu commented Jun 9, 2017

Thanks!

@elhigu elhigu merged commit 3d93166 into knex:master Jun 9, 2017
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants