Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the schema when dropping indices in Postgres. #2105

Merged
merged 1 commit into from Jun 9, 2017

Conversation

@ThePumpingLemma
Copy link
Contributor

@ThePumpingLemma ThePumpingLemma commented Jun 4, 2017

Ran into an issue where indices created using withSchema could not be dropped correctly since dropping couldn't take the schema into account.

Note that the name can optionally be schema qualified according to the documentation: https://www.postgresql.org/docs/9.6/static/sql-dropindex.html

@elhigu
Copy link
Member

@elhigu elhigu commented Jun 9, 2017

Seems legit, thanks!

@elhigu elhigu merged commit c18374e into knex:master Jun 9, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants