Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for right/rightOuterJoin combination #2117

Merged
merged 1 commit into from Jun 26, 2017

Conversation

@rizip1
Copy link
Contributor

@rizip1 rizip1 commented Jun 11, 2017

I found out that there is no unit test for right/rightOuterJoin so here is one that combines them both.
I do not include test for sqlite3 because it currently does not support right join.

* Do not include test for sqlite3 because it
  currently does not support right join
@elhigu elhigu merged commit 298a585 into knex:master Jun 26, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@elhigu
Copy link
Member

@elhigu elhigu commented Jun 26, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants