Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fullOuterJoin unit test #2118

Merged
merged 1 commit into from Jun 26, 2017
Merged

Add fullOuterJoin unit test #2118

merged 1 commit into from Jun 26, 2017

Conversation

@rizip1
Copy link
Contributor

@rizip1 rizip1 commented Jun 11, 2017

Add unit test for fullOuterJoin. No unitTest for MySQL and sqlite3 because they do not support it. Btw I found out that there is also outerJoin function which however will not work for any dialect. The issue is that it translates to OUTER JOIN ON ... which is not supported anywhere but FULL JOIN ON is supported in mssql, postgres and oracle so that is probably a bug.

@rizip1 rizip1 force-pushed the rizip1:unit-test-full-join branch from 2645d85 to 9fa52ae Jun 11, 2017
* No fullOuterJoin for MySQL and sqlite3
  because they do not support it
@rizip1 rizip1 force-pushed the rizip1:unit-test-full-join branch from 9fa52ae to 96158d0 Jun 13, 2017
@elhigu
Copy link
Member

@elhigu elhigu commented Jun 26, 2017

Thanks!

@elhigu elhigu merged commit d10b0d0 into knex:master Jun 26, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants