Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to knex.migrate.currentVersion causes an error #2111 #2123

Merged
merged 1 commit into from Oct 31, 2017

Conversation

koistya
Copy link
Contributor

@koistya koistya commented Jun 15, 2017

Fix #2111

@Industrial
Copy link

@Industrial Industrial commented Jun 22, 2017

Would love to see this change merged :-)

@elhigu
Copy link
Member

@elhigu elhigu commented Jun 26, 2017

@Industrial There is one test failing on node 0.12 and I would like to know why. It didn't look like a random failure (I've reran that test maybe 5 times). I haven't got time time to figure it out and this PR cannot be merged before it works.

Also if we go by the book with PRs, there should be test case included reproducing the original error, even though for this one I'm willing to make an exception.

@maxkoryukov
Copy link

@maxkoryukov maxkoryukov commented Jul 18, 2017

I think it is not a bad moment to drop support for Node < 4

@elhigu
Copy link
Member

@elhigu elhigu commented Jul 23, 2017

I dropped node 0.12 from master... this probably needs rebase, before travis will notice that test configuration was changed.

@elhigu
Copy link
Member

@elhigu elhigu commented Oct 31, 2017

All the necessary node version tests were fine, so I'm merging this in.

@elhigu elhigu merged commit f66b524 into knex:master Oct 31, 2017
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants