Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

searchPath should be case-sensitive #2172

Merged
merged 1 commit into from Jul 25, 2017
Merged

Conversation

@wubzz
Copy link
Member

@wubzz wubzz commented Jul 25, 2017

Previously {searchPath: 'TEST'} would result in test rather than TEST.

Fixes #1751

Previously `{searchPath: 'TEST'}` would result in `test` rather than `TEST`.
@wubzz wubzz merged commit 98025fa into knex:master Jul 25, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@smithamax
Copy link

@smithamax smithamax commented Nov 16, 2017

This seems to have broken multiple search paths. 'knex,public' becomes set search_path to "knex,public" but should be set search_path to "knex","public" I think.

@wubzz
Copy link
Member Author

@wubzz wubzz commented Nov 16, 2017

That makes sense, didn't have a single thought relating two multiple search paths. Can you open a new issue?

Also I think the syntax in that case should be ['knex', 'public'] instead of knex,public.

@wubzz
Copy link
Member Author

@wubzz wubzz commented Nov 16, 2017

Issue #2335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants