Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Escape table name in SQLite columnInfo call #2281

Merged
merged 1 commit into from Oct 23, 2017

Conversation

@Pinqvin
Copy link
Contributor

@Pinqvin Pinqvin commented Oct 21, 2017

Fixes #2184. Not escaping the table name could lead to errors with some table names (group, for example)

Fixes #2184. Not escaping the table name could lead to issues
with some table names. Table name group, for example, would
result in an error.
@Pinqvin
Copy link
Contributor Author

@Pinqvin Pinqvin commented Oct 21, 2017

Looks like tests are failing with Node 4.x version. Tried to reproduce this locally with 4.8.4 by running just the sqlite3 tests DB='sqlite3' npm test, but the tests seemed to run fine. Is this a random failure with the oracledb test set or am I missing something here?

@elhigu
Copy link
Member

@elhigu elhigu commented Oct 23, 2017

Yeah, that was just a random fail. PR seems good, I'll merge this when I see that tests are passing :) Thank you!

@elhigu elhigu merged commit fddfd3b into knex:master Oct 23, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants