Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql stream should support query options #2301

Merged
merged 1 commit into from Nov 5, 2017

Conversation

@jstewmon
Copy link
Contributor

@jstewmon jstewmon commented Nov 1, 2017

No description provided.

@jstewmon
Copy link
Contributor Author

@jstewmon jstewmon commented Nov 1, 2017

I don't have time to work on the other dialects at the moment, but it looks like maria and postgres _stream functions are also dropping options.

@jstewmon jstewmon force-pushed the jstewmon:mysql-stream-options branch from 3f4f69a to d604f01 Nov 2, 2017
@jstewmon
Copy link
Contributor Author

@jstewmon jstewmon commented Nov 2, 2017

Swapped Array.includes for lodash.includes to support node < 6

@elhigu
Copy link
Member

@elhigu elhigu commented Nov 5, 2017

Looks good, thanks!

@elhigu elhigu merged commit 7c1a0d4 into knex:master Nov 5, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants