Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed passing connection errors directly to the query #2336

Merged
merged 4 commits into from Nov 17, 2017

Conversation

@elhigu
Copy link
Member

@elhigu elhigu commented Nov 16, 2017

Fixes #2325

Problem was that pools create callback must never reject or pool tries to get the resource until acquireConnectionTimeout is triggered.

Sadly generic-pool doesn't allow to change that functionality so I had to write small workaround for it.

@elhigu elhigu merged commit e405d66 into knex:master Nov 17, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant