Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set toNative() to be not enumerable #2388

Merged
merged 1 commit into from Jan 3, 2018
Merged

Conversation

@godfrey-kao
Copy link
Contributor

@godfrey-kao godfrey-kao commented Dec 16, 2017

This would fix #2344

@elhigu
Copy link
Member

@elhigu elhigu commented Dec 29, 2017

Thanks! I'll merge after having successfull test run.

@elhigu
Copy link
Member

@elhigu elhigu commented Dec 29, 2017

Looks like oracle dropped support for node 5,7 and will drop 9 also soon oracle/node-oracledb#811 so I need to fix test setup to not install oracle stuff on non lts node versions..

@elhigu
Copy link
Member

@elhigu elhigu commented Jan 3, 2018

Tests which should have passed went through... merging

@elhigu elhigu merged commit 59f6cba into knex:master Jan 3, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants