Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug when using .returning (OUTPUT) in an update query with joins in MSSQL #2399

Merged
merged 1 commit into from Jan 1, 2018
Merged

Fixed a bug when using .returning (OUTPUT) in an update query with joins in MSSQL #2399

merged 1 commit into from Jan 1, 2018

Conversation

@tankers746
Copy link
Contributor

@tankers746 tankers746 commented Dec 30, 2017

When using OUTPUT with updates and a join in MSSQL the OUTPUT needs to come before
the joins.

https://stackoverflow.com/questions/4170389/inner-join-within-update-output-in-one-t-sql-query

@smorey2
Copy link
Collaborator

@smorey2 smorey2 commented Dec 30, 2017

Thabks for this fix, however I do not see a test included to make sure this is caught in the future.

Can you please add a test, also looks like the build is currently breaking for this commit. I am not at a computer rn to figure out why.

Can you make the build not break.

@tankers746
Copy link
Contributor Author

@tankers746 tankers746 commented Dec 30, 2017

It looks like the master branch is failing to build due to an issue installing oracledb.
Apologies, I'm not sure how I'd go about making a test.

@smorey2
Copy link
Collaborator

@smorey2 smorey2 commented Dec 30, 2017

@smorey2 smorey2 merged commit 3f89701 into knex:master Jan 1, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants