Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added knexTxId to query events and debug calls #2476

Merged
merged 4 commits into from Feb 21, 2018

Conversation

@wubzz
Copy link
Member

@wubzz wubzz commented Feb 16, 2018

Fixes #2379

@wubzz
Copy link
Member Author

@wubzz wubzz commented Feb 16, 2018

@elhigu Any thoughts on this one?

Would have preferred not to bloat the connection object even more, but feel its inevitable for what was requested, and I completely understand why this property is needed.

@wubzz wubzz force-pushed the wubzz:feature/knexTxId-in-events-and-debug branch from 43742c7 to 05dec24 Feb 17, 2018
})
)
.then(connection => {
connection.__knexTxId = this.txid;

This comment has been minimized.

@wubzz

wubzz Feb 17, 2018
Author Member

Not sure why this is not working, unable to test locally..

This comment has been minimized.

@elhigu

elhigu Feb 18, 2018
Member

I will setup docker, which runs oracle tests locally in container. node-oracledb driver is pretty painful to install on every platform 😬

This comment has been minimized.

@wubzz

wubzz Feb 18, 2018
Author Member

Yeah I tried installning on Windows, and I can vouch for the difficulty... 😥

This comment has been minimized.

@elhigu

elhigu Feb 18, 2018
Member

I don't see anything wrong either. I suppose this.txid is not set at this point. looks like in other places they are referring it with t.txid, but it shouldn't matter. Will be easier to figure out when tests can be ran locally.

This comment has been minimized.

@elhigu

elhigu Feb 19, 2018
Member

#2491 there is PR for adding npm script to run oracledb tests locally in docker container

This comment has been minimized.

@wubzz

wubzz Feb 21, 2018
Author Member

Took more time than I care to admit to find the issue. Turns out I only changed in dialects/oracle/transaction.js assuming that was what test was running, but it was actually running dialects/oracledb/transaction.js which I had forgotten to change

@elhigu
elhigu approved these changes Feb 21, 2018
Copy link
Member

@elhigu elhigu left a comment

👍

@wubzz wubzz merged commit 397104c into knex:master Feb 21, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants