Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed rm to rimraf in 'npm run dev' #2483

Merged
merged 1 commit into from Feb 18, 2018

Conversation

@wubzz
Copy link
Member

@wubzz wubzz commented Feb 18, 2018

This is primarly for environments where rm is not available, such as Windows without Git Bash.

rimraf is already a devDependecy so there is no extra cost in that department.

@wubzz
Copy link
Member Author

@wubzz wubzz commented Feb 18, 2018

Failing test is not related to this change and only applies to Node 8 (some oracledb test), merging.

@wubzz wubzz merged commit 2ed490c into knex:master Feb 18, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Copy link
Member

@elhigu elhigu left a comment

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants