Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DB schema for migrations - fixes #2499 #2559

Merged
merged 12 commits into from Apr 4, 2018
Merged

Support DB schema for migrations - fixes #2499 #2559

merged 12 commits into from Apr 4, 2018

Conversation

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Apr 4, 2018

refs #2499

@@ -23,6 +23,7 @@ const CONFIG_DEFAULT = Object.freeze({
'.co', '.coffee', '.eg', '.iced', '.js', '.litcoffee', '.ls', '.ts'
],
tableName: 'knex_migrations',
schemaName: null,

This comment has been minimized.

@kibertoad

kibertoad Apr 4, 2018
Author Collaborator

I've chosen this name to be consistent with currently used "tableName"

@@ -23,6 +23,7 @@ module.exports = {
"import/parser": "babel-eslint"
},
"env": {
"node": true
"node": true,
"mocha": true

This comment has been minimized.

@kibertoad

kibertoad Apr 4, 2018
Author Collaborator

Linting is complaining about afterEach usage otherwise.

@elhigu
Copy link
Member

@elhigu elhigu commented Apr 4, 2018

looks fine, thanks!

@elhigu elhigu merged commit 843a167 into knex:master Apr 4, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@elhigu
Copy link
Member

@elhigu elhigu commented Apr 4, 2018

Except documentation still has to be added.

@igor-savin-ht
Copy link
Contributor

@igor-savin-ht igor-savin-ht commented Apr 4, 2018

@elhigu No problem, I'll get to it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants