Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary Key for Migration Lock Table #2569

Merged
merged 2 commits into from Apr 25, 2018
Merged

Primary Key for Migration Lock Table #2569

merged 2 commits into from Apr 25, 2018

Conversation

@k00p
Copy link
Contributor

@k00p k00p commented Apr 13, 2018

In reference to #2534, the single line change has been run with tests against DB='mysql' npm test.

Summary

  total:     84
  passing:   84
  duration:  1.6s

Full result

testIssue2534.txt

@k00p
Copy link
Contributor Author

@k00p k00p commented Apr 13, 2018

Related documentation PR:
knex/documentation#105

@k00p
Copy link
Contributor Author

@k00p k00p commented Apr 13, 2018

Updated PR to include creation of an increments 'index' column as primary key as suggested.

Summary

  total:     84
  passing:   84
  duration:  1.5s

Full Result

testIssue2534.txt

@k00p
Copy link
Contributor Author

@k00p k00p commented Apr 13, 2018

Looks like there was a glitch with the Travis CI build (Oracle download error - they have very poor open source hygiene in my experience). Closing an reopening PR to trigger another build.

@k00p k00p closed this Apr 13, 2018
@k00p
Copy link
Contributor Author

@k00p k00p commented Apr 13, 2018

Reopening to trigger new build.

@k00p k00p reopened this Apr 13, 2018
k00p added a commit to k00p/documentation that referenced this pull request Apr 17, 2018
Updates documentation to clarify [Pull 2569](knex/knex#2569) changes.
@elhigu
Copy link
Member

@elhigu elhigu commented Apr 25, 2018

Looks great, thanks!

@elhigu elhigu merged commit 2159f8f into knex:master Apr 25, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@k00p
Copy link
Contributor Author

@k00p k00p commented Apr 26, 2018

Thanks - happy to be able to contribute.

elhigu added a commit to knex/documentation that referenced this pull request Jul 2, 2018
Updates documentation to clarify [Pull 2569](knex/knex#2569) changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants