Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure knex.destroy() returns a bluebird promise #2589

Merged
merged 1 commit into from May 3, 2018

Conversation

@devinivy
Copy link
Contributor

@devinivy devinivy commented May 2, 2018

Tarn's destroy() method doesn't return a bluebird promise, which means knex's destroy() method currently does not return a bluebird promise. With this change, it should again :)

@elhigu
elhigu approved these changes May 3, 2018
Copy link
Member

@elhigu elhigu left a comment

Looks good.

@elhigu elhigu merged commit 3bed888 into knex:master May 3, 2018
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@devinivy devinivy deleted the devinivy:bluebird-destroy branch May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants