Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cache node_modules #2595

Merged
merged 6 commits into from May 14, 2018
Merged

chore: cache node_modules #2595

merged 6 commits into from May 14, 2018

Conversation

@DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented May 4, 2018

No description provided.

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented May 4, 2018

What are the benefits of this?

@DanielRuf
Copy link
Contributor Author

@DanielRuf DanielRuf commented May 4, 2018

It caches the node_modules and is partly an alternative to npm ci. If there is a cache with the same deps it will load the cache instead of installing all deps again = faster builds.

@DanielRuf DanielRuf changed the title chore: use yarn cache chore: cache node_modules May 4, 2018
@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented May 4, 2018

Hell yeah, difference seems to be quite noticeable.

@DanielRuf
Copy link
Contributor Author

@DanielRuf DanielRuf commented May 4, 2018

Can be probably better in combination with the other PRs and with following builds / PRs.

Unfortunately the env is not the best for all cases https://docs.travis-ci.com/user/reference/overview/#Virtualisation-Environment-vs-Operating-System

@elhigu
Copy link
Member

@elhigu elhigu commented May 14, 2018

This seems like a good idea 👍 I have experienced issues with CI npm caches earlier (not updating to new versions to libs properly etc.), but I think we can give this a shot to see if there are any drawbacks this time (I have never used travis cache).

@elhigu elhigu merged commit e3beaf2 into knex:master May 14, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@elhigu
Copy link
Member

@elhigu elhigu commented May 14, 2018

thanks!

@DanielRuf
Copy link
Contributor Author

@DanielRuf DanielRuf commented May 14, 2018

This seems like a good idea 👍 I have experienced issues with CI npm caches earlier (not updating to new versions to libs properly etc.), but I think we can give this a shot to see if there are any drawbacks this time (I have never used travis cache).

If this cache strategy creates any problems we can also try $HOME/.npm as alternative. So fr I saw no issues with the current cache strategy.

@DanielRuf DanielRuf deleted the DanielRuf:chore/use-yarn-cache branch May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants