New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSSQL removes support column width/length on data type int #2738
Conversation
- fixes error `Cannot specify a column width on data type int` - ignore length even if pass as agrument
b6a461a
to
053c412
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs integration test.
@elhigu Most of current integration test are now using |
So if current integration tests are creating integers with specific width how come current integration tests are not throwing that error? |
@elhigu upon looking, there is no MSSQL integration test that uses specific width which explains integration tests are not throwing. |
@kamote thanks for looking that up. In that case such test should be added (regression test to make sure the same thing will not start failing again). |
@kamote Could you give me write access on your repo so that I could add test? |
@kibertoad did you try just to pull it and push changes? I have usually been able to do that... if it doesnt work, you can create your own PR also and link it here 👍 |
Cannot specify a column width on data type int