Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nyc version #2810

Merged
merged 1 commit into from Sep 17, 2018
Merged

Update nyc version #2810

merged 1 commit into from Sep 17, 2018

Conversation

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Sep 17, 2018

Latest PRs are showing some strange deviations in code coverage percentage. Hopefully bumping nyc version would make it more consistent across baseline and new PRs.

@kibertoad
Copy link
Collaborator Author

@kibertoad kibertoad commented Sep 17, 2018

@elhigu Right, so force merging this should theoretically update the baseline code coverage to correct value and other outstanding PRs won't fail anymore.

@elhigu elhigu merged commit f01d5fa into knex:master Sep 17, 2018
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-3.2%) to 85.663%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kibertoad kibertoad deleted the transient-team:general/update-dev-dependencies branch Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants