Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript migration stub #2816

Merged
merged 2 commits into from Sep 27, 2018
Merged

Typescript migration stub #2816

merged 2 commits into from Sep 27, 2018

Conversation

@anggiaj
Copy link
Contributor

@anggiaj anggiaj commented Sep 24, 2018

add typings on typescript migration stub

@@ -1,15 +1,15 @@
import * as Knex from "knex";

exports.up = function (knex: Knex): Promise<any> {
export async function up(knex: Knex): Promise<Knex.SchemaBuilder> {

This comment has been minimized.

@elhigu

elhigu Sep 26, 2018
Member

I don't thing tat typing is right. AFAIK Migration does not always resolve with Knex.SchemaBuilder instance.

This comment has been minimized.

@anggiaj

anggiaj Sep 26, 2018
Author Contributor

updated

@elhigu
Copy link
Member

@elhigu elhigu commented Sep 26, 2018

thanks, now it looks good :) gotta wait for tests to finish though.

@elhigu elhigu merged commit 0bcdcec into knex:master Sep 27, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+2.8%) to 88.504%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants