Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whereColumn #2837

Merged
merged 5 commits into from Oct 3, 2018
Merged

whereColumn #2837

merged 5 commits into from Oct 3, 2018

Conversation

@tgriesser
Copy link
Member

@tgriesser tgriesser commented Oct 3, 2018

Syntax for getting rid of the problem of doing a where clause with column bindings

@tgriesser tgriesser force-pushed the where-column branch from 0083a36 to 50c497b Oct 3, 2018
@tgriesser tgriesser merged commit 051bdc7 into master Oct 3, 2018
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.1%) to 84.63%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tgriesser tgriesser deleted the where-column branch Oct 3, 2018
@tgriesser
Copy link
Member Author

@tgriesser tgriesser commented Oct 3, 2018

Needs docs, but should be good to go.

@elhigu
Copy link
Member

@elhigu elhigu commented Oct 8, 2018

Added issue about missing documentation.

Also IMO .where('column', '=', knex.ref('othercolumn')) would have been sufficient syntax to support that use case and to keep number of different API method variants smaller.

@tgriesser
Copy link
Member Author

@tgriesser tgriesser commented Oct 8, 2018

True, but it's such a common use case I think it justifies the inclusion as a top level method. Also with the code I'm working on here I'd eventually like to get rid of the need for knex.ref with better API design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants