Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for named unique, primary and foreign keys to SQLite3 #2840

Merged
merged 8 commits into from Oct 11, 2018

Conversation

@kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Oct 7, 2018

This is a version of #2056 that was synced against the master and formatted.
refs #2051

@kibertoad kibertoad closed this Oct 7, 2018
@kibertoad kibertoad reopened this Oct 7, 2018
@kibertoad
Copy link
Collaborator Author

@kibertoad kibertoad commented Oct 7, 2018

@elhigu @tgriesser Would be nice to get this into current release window as it's a breaking change. Considering that solution itself was reviewed and iterated upon multiple times within the scope of #2056, I assume that this should be ready to go in current state.

Loading

@kibertoad
Copy link
Collaborator Author

@kibertoad kibertoad commented Oct 10, 2018

So what's the plan for this one? Shall we include it in 0.16.0 or wait till next major release?

Loading

@elhigu elhigu merged commit 96a8e3a into knex:master Oct 11, 2018
2 checks passed
Loading
@elhigu
Copy link
Member

@elhigu elhigu commented Oct 11, 2018

Thanks!

Loading

@elhigu
Copy link
Member

@elhigu elhigu commented Oct 11, 2018

I'm not sure if this needs some changes to documentation?

Loading

@kibertoad
Copy link
Collaborator Author

@kibertoad kibertoad commented Oct 11, 2018

@elhigu From my understanding it doesn't, it actually makes SQLite dialect to adhere better to what is already documented.

Loading

@kibertoad kibertoad deleted the sqlite-named-constraints branch Oct 11, 2018
@elhigu
Copy link
Member

@elhigu elhigu commented Oct 11, 2018

Yep, unless there are mentions about sqlite not supporting some features.

Loading

@kibertoad
Copy link
Collaborator Author

@kibertoad kibertoad commented Oct 11, 2018

Checked it, doesn't seem like it.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants